Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: correct a typo #253

Merged
merged 1 commit into from
Mar 24, 2023
Merged

metrics: correct a typo #253

merged 1 commit into from
Mar 24, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Mar 24, 2023

What problem does this PR solve?

Issue Number: close None

Problem Summary: When testing in TiDB cloud, .* is needed (grafana definition is different on Cloud, there are some hacks). It is wrongly copied back to the original file causing problems.

图片

图片

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 March 24, 2023 05:54
@djshow832 djshow832 merged commit 05b9446 into pingcap:main Mar 24, 2023
@xhebox xhebox deleted the mm branch March 24, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants