Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend, router: add IO timeout when the backend is unhealthy #228

Closed
wants to merge 2 commits into from
Closed

backend, router: add IO timeout when the backend is unhealthy #228

wants to merge 2 commits into from

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Mar 3, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #229

Problem Summary:
When the backend is unhealthy, the queries may block. We need to fail fast.

What is changed and how it works:
Add IO timeout when the backend is unhealthy.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox xhebox self-requested a review March 3, 2023 13:38
@djshow832 djshow832 closed this Mar 5, 2023
@djshow832 djshow832 deleted the io_timeout branch September 2, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Queries may block when the backend is down
1 participant
@djshow832