*: remove docs and update readme #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhebox
reviewed
Feb 23, 2023
Comment on lines
+122
to
+124
| [security] | ||
| session-token-signing-cert = "/var/sess/cert.pem" | ||
| session-token-signing-key = "/var/sess/key.pem" |
There was a problem hiding this comment.
This is auto-set if tlsCluster: true, maybe notice that?
There was a problem hiding this comment.
What about additionalVolumes and additionalVolumeMounts? Will they be auto set?
There was a problem hiding this comment.
Yes, you don't need to do anything if tlsCluster: true.
But you will need to create 4 or 5 certs for each component... That said when tlsCluster: true, certs will not be created automatically.
xhebox
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close None
Problem Summary:
The doc and readme are stale.
What is changed and how it works:
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.