api: refactor config API to adapt tidb-operator/TOML changes #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xhe <xw897002528@gmail.com>
xhebox
commented
Jan 6, 2023
| @@ -118,12 +117,11 @@ func TestUpdateCfg(t *testing.T) { | |||
| err := os.RemoveAll(dir) | |||
| require.NoError(t, err) | |||
|
|
|||
| clonedCfg := cfg.LogOnline | |||
| test.updateCfg(&clonedCfg) | |||
| // Push it 2 times to make sure the first one has already taken affect. | |||
There was a problem hiding this comment.
Our kvmap impl will not suffer problems like etcd, no need to put 2 times.
xhebox
commented
Jan 6, 2023
Signed-off-by: xhe <xw897002528@gmail.com>
10 tasks
djshow832
reviewed
Jan 9, 2023
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| return | ||
| case cfg := <-cfgCh: | ||
| case acfg := <-cfgch: | ||
| cfg := &acfg.Log.LogOnline |
There was a problem hiding this comment.
If the event type is delete, acfg is empty.
There was a problem hiding this comment.
No delete in the current implementation.
And it is ensured to be valid pointer:
var c config.Config
if k.Type == KVEventDel {
ch <- &c
} else {
It is valid if user wants to reset to default, for example.
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
approved these changes
Jan 10, 2023
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
xhebox
added a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 7, 2023
xhebox
added a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Issue Number: ref #161
Problem Summary: Due to we have adapt
ConfigWrapperintidb-operator, it becomes harder to set config for each component separately. Further more, we need to issue two requests for each instace. Instead, we just upload the whole config, and pick updatable part now.What is changed and how it works:
config [log | proxy] [get | put]is replaced by one single commandtiproxyctl config get/putXXXOnlineConfigare replaced bychan *config.ConfigConfigManager.Init()Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.