-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend: use BackendConnMgr as ConnContext #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
xhebox
commented
Jan 5, 2023
Comment on lines
-238
to
-240
host, _, err := net.SplitHostPort(inAddr) | ||
require.NoError(t, err) | ||
require.Equal(t, host, "::1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I do want to keep the test, the logic of ClientAddr()
moves to BackendConnMgr
instead of Authenticator
. Also, this test will fail on linux without IPV4. So I just removed it, maybe test BackendConnMgr
more later.
djshow832
reviewed
Jan 6, 2023
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
approved these changes
Jan 9, 2023
xhebox
added a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 7, 2023
xhebox
added a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Issue Number: close #174
Problem Summary: A cleanup/refactor PR for backend, proposed when thinking on how to implement compression protocol elegantly(most logic will be in
Authenticator
). Check #174.What is changed and how it works:
ctxmap
andclientAddr
, the core ofConnContext
API intoBackendConnMgr
supportedServerCapabilities
, replaced byhandshakeHandler.GetCapability()
WriteInitialHandshake()
,readInitialHandshake()
andParseInitialHandshake()
now usepnet.Capability
instead ofuint32
writeAuthHandshake
and share common code inhandshakeFirstTime
andhandshakeSecondTime
WithRemoteAddr()
to*PacketIO
. NowPacketIO.RemoteAddr()
will return the given remote addr if any.clientIO.SourceAddr()
, which is solely used by proxy protocol. It is now replaced by the newWithRemoteAddr()+RemoteAddr()
comb.BackendConn
, which only has one useful methodAddr()
, replaced by the newWithRemoteAddr()+RemoteAddr()
.auth.serverAddr
, which is used by TLS handshake, replaced by the newWithRemoteAddr()+RemoteAddr()
.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.