Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: adapt to toml #165

Merged
merged 3 commits into from
Dec 27, 2022
Merged

*: adapt to toml #165

merged 3 commits into from
Dec 27, 2022

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Dec 27, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: ref #161

Problem Summary: TOML is more convenient in TiDB environment.

What is changed and how it works:

  1. all yaml to toml
  2. TLS .Warn() logs are changed to .Info()
  3. tiproxycli defaults to warn loglevel now, so that the output of commands(e.g. tiproxyctl namespace list) is a operatational TOML output.
  4. add make tidy

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
tiproxyctl namespace list
tiproxyctl namespace import conf/namespace
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox xhebox requested a review from djshow832 December 27, 2022 09:55
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit d642637 into pingcap:main Dec 27, 2022
@xhebox xhebox deleted the dedicate_1 branch December 27, 2022 12:55
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants