router: refactor creation of backendFetcher #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
xhebox
approved these changes
Dec 2, 2022
xhebox
pushed a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 7, 2023
xhebox
pushed a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
Move the logic of creating different types of backendFetchers out of router. So that we can easily create a
NewScoreBasedRouterorNewBackendObserverwith custom backend fetcher, without getting plagued by the etcd client and addrs parameters.Check List
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.