backend: Add HandshakeHandler to customize handling handshake #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhebox
reviewed
Dec 1, 2022
| @@ -82,7 +83,7 @@ func (auth *Authenticator) writeProxyProtocol(clientIO, backendIO *pnet.PacketIO | |||
| } | |||
|
|
|||
| func (auth *Authenticator) verifyBackendCaps(logger *zap.Logger, backendCapability pnet.Capability) error { | |||
| requiredBackendCaps := defRequiredBackendCaps | |||
| requiredBackendCaps := defRequiredBackendCaps & pnet.Capability(auth.capability) | |||
There was a problem hiding this comment.
Why? We don't do the verification for client and server, I think...
There was a problem hiding this comment.
verifyBackendCaps verifies that TiDB also has capability ClientDeprecateEOF. But if TiProxy doesn't enable ClientDeprecateEOF with the client, it shouldn't require ClientDeprecateEOF from the TiDB.
xhebox
approved these changes
Dec 1, 2022
xhebox
pushed a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 7, 2023
xhebox
pushed a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close None
Problem Summary:
The gateway needs to choose a namespace by username and rewrite handshake response.
What is changed and how it works:
BackendConnManagercallsHandshakeHandler.GetNamespace()andHandshakeHandler.GetCapability()AuthenticatorcallsHandshakeHandler.HandleHandshakeResp()to rewrite handshake responseattrsbecause the gateway will use itCheck List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.