Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add back salt #134

Merged
merged 1 commit into from
Nov 11, 2022
Merged

*: add back salt #134

merged 1 commit into from
Nov 11, 2022

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Nov 8, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: close None

Problem Summary: The fake salt does not have any usage. But client will still send the computed passwords with the fake salt in the response. In cases of non-TLS, all-zero salt will let client send a fixed auth string(sha1 three times with fixed input), which is highly insecure. Thus we should still send random salt instead.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 November 8, 2022 06:14
@djshow832 djshow832 merged commit d482ba1 into pingcap:main Nov 11, 2022
@xhebox xhebox deleted the log branch November 11, 2022 07:24
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants