Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: remove useless fields, fix tests #12

Merged
merged 1 commit into from
Jul 25, 2022
Merged

config: remove useless fields, fix tests #12

merged 1 commit into from
Jul 25, 2022

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jul 25, 2022

What problem does this PR solve?

Issue Number: ref #11

Problem Summary: Remove useless config fields.

What is changed and how it works:

  1. all frontend configs are removed for now
  2. breaker, ratelimiter and other API are deleted as needed
  3. UT tests for pkg/config is fixed

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox
config: remove useless fields
6201f4d 
We can add them back later if needed. But for now, they are safe to be
removed. This PR will prepare for the refactor of namespace manager.

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 July 25, 2022 07:03
@djshow832 djshow832 merged commit 2a653c3 into pingcap:main Jul 25, 2022
@xhebox xhebox mentioned this pull request Jul 25, 2022
Closed
5 tasks
@xhebox xhebox deleted the config branch July 25, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhebox @djshow832