Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: enable non-TLS connection to TiDB #117

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Oct 19, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: ref #69

Problem Summary: Dev tier has a safe private network, where TLS is unnecessary. Add requireBackendTLS to skip TLS if necessary.

What is changed and how it works:

  1. proxy.require-backend-tls = true by default
  2. add /pkg/sctx, which removed internal cfg.Cluster field from /lib/config/proxy.go
  3. Fix wrapping errors, where Is(Wrap(e1, e2), e2) == false
  4. Fix client EOF error supression
  5. Fix docker build

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    set proxy.require-backend-tls = false, start tiproxy and you should be able to connect to tiup playground without setting auto-tls = true
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 October 19, 2022 06:15
@xhebox xhebox mentioned this pull request Oct 19, 2022
9 tasks
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit 9542e0c into pingcap:main Oct 19, 2022
@xhebox xhebox deleted the tls_2 branch October 26, 2022 06:22
@xhebox xhebox mentioned this pull request Oct 31, 2022
8 tasks
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants