Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: improve docker scripts #104

Merged
merged 2 commits into from
Oct 8, 2022
Merged

*: improve docker scripts #104

merged 2 commits into from
Oct 8, 2022

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Sep 30, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: close None

Problem Summary: as title.

What is changed and how it works:

  1. shrink docker image size
  2. add make docker-release using docker buildx to push multiple-platform iamges
  3. continue to improve CI hit things: always fully update cache after merging, only download cache for PRs. It is actually harder than expected to archive the effect.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 September 30, 2022 08:27
Signed-off-by: xhe <xw897002528@gmail.com>
@@ -1 +0,0 @@
.gitignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?

!**/*.go
!**/*.mod
!**/*.sum

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need Makefile, too. We need to keep adding new source file types into the list. It makes no difference with adding new ignoring file types.

@djshow832 djshow832 merged commit c46acb9 into pingcap:main Oct 8, 2022
@xhebox xhebox deleted the docker_2 branch October 8, 2022 07:23
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants