cdc, pkg/txnutil: skip resolve lock during puller initialization #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
amyangfei
reviewed
Sep 4, 2020
cdc/puller/puller.go
Outdated
Comment on lines
233
to
236
| log.Info("puller is initialized", | ||
| zap.Duration("duration", time.Since(start)), | ||
| zap.String("changefeedid", changefeedID), | ||
| zap.Uint64("resolvedTs", resolvedTs)) |
Signed-off-by: Neil Shen <overvenus@gmail.com>
…venus/ticdc into reduce-resolve-lock-and-log
|
PTAL |
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/lgtm |
ti-srebot
approved these changes
Sep 4, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
overvenus
commented
Sep 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
===========================================
Coverage 33.8676% 33.8676%
===========================================
Files 99 99
Lines 12165 12165
===========================================
Hits 4120 4120
Misses 7641 7641
Partials 404 404 |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-integration-tests |
|
@overvenus merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR skips resolve lock during puller initialization and suppress some verbose log.
What is changed and how it works?
By adding a new API to check whether a puller is initialized or not.
Check List
Tests
Code changes
Related changes
Release note