-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/sink(ticdc): iterate all Kafka configs to support KOP (#8893) #8904
pkg/sink(ticdc): iterate all Kafka configs to support KOP (#8893) #8904
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/test verify maybe it's a bug in prow, the status is passed, but no link reported. |
@wuhuizuo: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test verify |
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
2514e76
to
2beddcd
Compare
95d8f96
to
d9ea537
Compare
Signed-off-by: hi-rustin <rustin.liu@gmail.com> Fix import Signed-off-by: hi-rustin <rustin.liu@gmail.com> Fix Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Tested locally:
|
/run-all-tests |
/run-dm-compatibility-tests |
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 21ea26d
|
/run-all-tests |
/run-integration-test |
/run-kafka-integration-test |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #8893
What problem does this PR solve?
Issue Number: close #8892
What is changed and how it works?
Iterate all Kafka configs to support KOP.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note