Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capture (ticdc): fix processor exit unexpectedly when some pd node fail #8884

Merged
merged 4 commits into from
May 6, 2023
Merged

capture (ticdc): fix processor exit unexpectedly when some pd node fail #8884

merged 4 commits into from
May 6, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented May 5, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8877 #8868

What is changed and how it works?

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. deploy 1 tidb cluster with 3 pd and 2 cdc.
  2. create a changefeed
  3. kill pd leader
  4. no cdc processor exit abnormally

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Fix processor exit unexpectedly when some pd node fail

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 5, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hicqu
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2023
@asddongmen
Copy link
Contributor Author

/test all

@asddongmen
Copy link
Contributor Author

/test all

@asddongmen
Copy link
Contributor Author

/test all

@asddongmen
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2023
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 9d5cf82

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2023
@asddongmen
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels May 6, 2023
@asddongmen
Copy link
Contributor Author

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2023

@asddongmen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-storage-test a3d75d1 link true /test cdc-integration-storage-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2023

@asddongmen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 648fe8a into pingcap:master May 6, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 6, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8898.

@ti-chi-bot ti-chi-bot mentioned this pull request May 6, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8900.

@ti-chi-bot ti-chi-bot mentioned this pull request May 6, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8901.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 6, 2023
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#8884
de50756 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request May 8, 2023
@ti-chi-bot
capture (ticdc): fix processor exit unexpectedly when some pd node fa…
09c43f4 
…il (#8884) (#8900)

ref #8868, close #8877
@asddongmen asddongmen mentioned this pull request May 8, 2023
Closed
ti-chi-bot bot pushed a commit that referenced this pull request May 15, 2023
@ti-chi-bot
capture (ticdc): fix processor exit unexpectedly when some pd node fa…
0287295 
…il (#8884) (#8898)

ref #8868, close #8877
@asddongmen asddongmen deleted the fix_processor_exit_unexpectedly branch May 18, 2023 05:28
ti-chi-bot bot pushed a commit that referenced this pull request Jun 13, 2023
@ti-chi-bot
pd, changefeed (ticdc): fix pd related issues (#8884, #8813, #9106, #…
1ea99d5 
…9174) (#8901)

ref #8868, close #8877
@asddongmen asddongmen mentioned this pull request Jun 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicqu hicqu hicqu approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDC changefeed stucks after killing PD owner
4 participants
@asddongmen @ti-chi-bot @hicqu @nongfushanquan