-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner(ticdc): fix changefeed state is automatically changed bug (#8331) #8350
owner(ticdc): fix changefeed state is automatically changed bug (#8331) #8350
Conversation
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 27df1b3
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1fd0bfb
|
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-6.1 #8350 +/- ##
================================================
Coverage ? 58.7959%
================================================
Files ? 814
Lines ? 107788
Branches ? 0
================================================
Hits ? 63375
Misses ? 38758
Partials ? 5655 |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #8331
What problem does this PR solve?
Issue Number: close #8330
What is changed and how it works?
When we handle the error of a stopped changefeed, the changefeed would be set to error state and retried by the owner. This behavior is unexpected. After this PR, TiCDC will not handle stopped changefeed errors and will just log them.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note