perf: optimize get tso frequency #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zier-one
reviewed
Jul 28, 2020
cdc/kv/client.go
Outdated
| @@ -251,6 +252,8 @@ type CDCClient struct { | |||
|
|
|||
| regionCache *tikv.RegionCache | |||
| kvStorage tikv.Storage | |||
|
|
|||
| currentVersionCache tidbkv.Version | |||
There was a problem hiding this comment.
Suggested change
| currentVersionCache tidbkv.Version | |
| currentVersionCache model.Ts |
zier-one
reviewed
Jul 28, 2020
cdc/kv/client.go
Outdated
| select { | ||
| case <-ctx.Done(): | ||
| return | ||
| case <-ticker.C: |
There was a problem hiding this comment.
if there is no region to resolve lock, we still query the tso from pd every two seconds?
zier-one
reviewed
Jul 28, 2020
cdc/kv/client.go
Outdated
| // GetCurrentVersion gets a cached version that is regularly updated by a background goroutine | ||
| func (c *CDCClient) GetCurrentVersion() tidbkv.Version { | ||
| for atomic.LoadUint64(&c.currentVersionCache.Ver) == 0 { | ||
| time.Sleep(1 * time.Second) |
overvenus
reviewed
Jul 28, 2020
cdc/kv/client.go
Outdated
| @@ -286,6 +308,14 @@ func (c *CDCClient) Close() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // GetCurrentVersion gets a cached version that is regularly updated by a background goroutine | |||
| func (c *CDCClient) GetCurrentVersion() tidbkv.Version { | |||
There was a problem hiding this comment.
How many CDCClient would CDC create? How about caching the TS in the processor?
liuzix
force-pushed
the
zixiong-tso-optimization
branch
from
fb3f770 to
5c722b0
Compare
|
/run-all-tests |
amyangfei
reviewed
Jul 30, 2020
cdc/puller/puller.go
Outdated
| return tidbkv.Version{Ver: ver}, nil | ||
| } | ||
|
|
||
| func (s *kvStorageWithVersionCache) Close() error { |
There was a problem hiding this comment.
Where is the Close called
cdc/puller/puller.go
Outdated
| @@ -15,6 +15,7 @@ package puller | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/pingcap/ticdc/pkg/notify" | |||
There was a problem hiding this comment.
Please move this import to the group of third-party lib
zier-one
reviewed
Jul 30, 2020
cdc/puller/puller.go
Outdated
| @@ -69,6 +166,7 @@ func NewPuller( | |||
| spans []regionspan.Span, | |||
| limitter *BlurResourceLimitter, | |||
| ) Puller { | |||
| kvStorage = newKvStorageWithVersionCache(kvStorage) | |||
There was a problem hiding this comment.
KvStorageWithVersionCache should be globally unique, not one per puller.
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
liuzix
changed the title
liuzix
force-pushed
the
zixiong-tso-optimization
branch
from
ccdae04 to
c1dc174
Compare
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
===========================================
Coverage 32.4447% 32.4447%
===========================================
Files 96 96
Lines 10541 10541
===========================================
Hits 3420 3420
Misses 6780 6780
Partials 341 341 |
liuzix
changed the title
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
zier-one
approved these changes
Aug 3, 2020
ti-srebot
approved these changes
Aug 3, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Querying CurrentVersion too frequently when resolving lock. #790
What is changed and how it works?
CurrentVersion is now cached and is updated regularly by a separate goroutine.
Check List
Tests
Code changes
Release note