Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader(dm): remove loader and ColumnMapping and dump TLS certs #7940

Merged
merged 28 commits into from
Dec 26, 2022
Merged

loader(dm): remove loader and ColumnMapping and dump TLS certs #7940

merged 28 commits into from
Dec 26, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Dec 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #3510

What is changed and how it works?

loader is replaced by embedded lightning, column mapping is replaced by extract-table/database/source, and lightning can use cert bytes so no need to dump the content.

Check List

Tests

  • pass old tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 20, 2022
@lance6716 lance6716 changed the title loader(dm): remove loader [WIP]loader(dm): remove loader Dec 20, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 20, 2022
@lance6716
remove more
f6f5b7e 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix some UT
3eb55d4 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP]loader(dm): remove loader [WIP]loader(dm): remove loader and ColumnMapping Dec 20, 2022
@lance6716
fix more
1ddc651 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix more
65b3588 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix fmt
49f05c5 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix fmt
1ce46a1 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix again
cf9a4ee 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix
3f82708 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix make fmt
3235b15 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix again
e340ab7 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix another UT
095cab9 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix go-generate
568e16e 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
sync code
2a8474a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
2f8fe91 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
afd72ec 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
de8c344
@lance6716
Copy link
Contributor Author

waiting pingcap/tidb-tools#690

@lance6716
sync code
a5bc678 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
50420e6 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
2b94ebb 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP]loader(dm): remove loader and ColumnMapping [WIP]loader(dm): remove loader and ColumnMapping and dump TLS certs Dec 21, 2022
@lance6716
sync code
2acfa12 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
should finish
615f2cd 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

2 similar comments
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
sync code
781a65a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix CI
26fea3a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
sync code
dfa2359 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

1 similar comment
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716 lance6716 changed the title [WIP]loader(dm): remove loader and ColumnMapping and dump TLS certs loader(dm): remove loader and ColumnMapping and dump TLS certs Dec 22, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2022
@lance6716
Copy link
Contributor Author

/cc @buchuitoudegou @GMHDBJD @lichunzhu

lichunzhu
lichunzhu approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2022
GMHDBJD
GMHDBJD approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 26, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5fd3e73

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 26, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a98f447 into pingcap:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@buchuitoudegou buchuitoudegou Awaiting requested review from buchuitoudegou

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-chi-bot @lichunzhu @GMHDBJD