Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning(dm): use working directory for sort-kv when source-dir is S3 #7919

Merged
merged 18 commits into from
Dec 20, 2022
Merged

lightning(dm): use working directory for sort-kv when source-dir is S3 #7919

merged 18 commits into from
Dec 20, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Dec 15, 2022 •
edited
Loading

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: ref #3510

What is changed and how it works?

as title

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@lance6716
lightning(dm): use working directory for sort-kv when source-dir is S3
9f798e9 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Dec 15, 2022
@lance6716 lance6716 changed the title lightning(dm): use working directory for sort-kv when source-dir is S3 [WIP]lightning(dm): use working directory for sort-kv when source-dir is S3 Dec 15, 2022
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 15, 2022
@lance6716
sync code
ea35998 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
80b3e47 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Merge branch 'master' of github.com:pingcap/tiflow into sort-dir
e589ba6
@lance6716
sync code
d02f73e 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
revert engine change
a25bb6c 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
31a7b08 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
add test
da4839f 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
7a2cc58 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
6d6e97f 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP]lightning(dm): use working directory for sort-kv when source-dir is S3 lightning(dm): use working directory for sort-kv when source-dir is S3 Dec 16, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2022
@lance6716
sync code
fd9c18e 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
905ddf6 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2022
@lance6716
sync code
4894106 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
sync code
f5f3fa7 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2022
@lance6716
Copy link
Contributor Author

/cc @gozssky @buchuitoudegou

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 20, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5dce721

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2022
@lance6716
fix CI
da8c33c 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: da8c33c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2022
@lance6716
Copy link
Contributor Author

/merge

@lance6716
Copy link
Contributor Author

/merge

@lance6716
Copy link
Contributor Author

/run-engine-integration-test

1 similar comment
@lance6716
Copy link
Contributor Author

/run-engine-integration-test

@ti-chi-bot ti-chi-bot merged commit dd0db99 into pingcap:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepymole sleepymole sleepymole approved these changes

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-chi-bot @sleepymole @buchuitoudegou