Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add savepoint integration tests #7378

Merged
merged 11 commits into from
Oct 18, 2022

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Oct 17, 2022

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Issue Number: close #7387

What is changed and how it works?

Related PR: pingcap/tidb#34466

Check List

Tests

  • Integration test
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 17, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Oct 17, 2022
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2022
@overvenus
Copy link
Member

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

@overvenus
Copy link
Member

/run-integration-tests

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor Author

/run-integration-tests

@crazycs520
Copy link
Contributor Author

/run-integration-tests

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please link to an issue.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #7378 (c66124b) into master (84ef430) will increase coverage by 0.0599%.
The diff coverage is 76.8456%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.6227% <76.8456%> (+0.1282%) ⬆️
dm 51.9576% <ø> (-0.0136%) ⬇️
engine 60.8536% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7378        +/-   ##
================================================
+ Coverage   59.7990%   59.8589%   +0.0599%     
================================================
  Files           801        802         +1     
  Lines         91968      92048        +80     
================================================
+ Hits          54996      55099       +103     
+ Misses        32180      32160        -20     
+ Partials       4792       4789         -3     

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 18, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: db013c6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 18, 2022
@ti-chi-bot
Copy link
Member

@crazycs520: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d117b70 into pingcap:master Oct 18, 2022
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Oct 19, 2022
@crazycs520 crazycs520 deleted the savepoint-test branch November 3, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add savepoint test
5 participants