mysql-sink: add more performance related metrics #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
|
/run-integration-tests |
overvenus
reviewed
Jun 29, 2020
Comment on lines
+52
to
+58
| bucketSizeCounter = prometheus.NewCounterVec( | ||
| prometheus.CounterOpts{ | ||
| Namespace: "ticdc", | ||
| Subsystem: "sink", | ||
| Name: "bucket_size", | ||
| Help: "size of the DML bucket", | ||
| }, []string{"capture", "changefeed", "bucket"}) |
There was a problem hiding this comment.
Looks like gauge is more suitable for size.
There was a problem hiding this comment.
Because the sink worker flushes DMLs every 100ms, it is hard to track real bucket size if using gauge, so here use a counter instead.
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #702 +/- ##
===========================================
Coverage 31.4172% 31.4172%
===========================================
Files 90 90
Lines 9307 9307
===========================================
Hits 2924 2924
Misses 6143 6143
Partials 240 240 |
|
/merge |
|
/run-integration-tests |
amyangfei
added
component/sink
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Solve #685
What is changed and how it works?
Check List
Tests
Related changes
Release note