Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cyclic, cmd: qoute cyclic table name, fatal if loopback and fix a data race #701

Merged
merged 8 commits into from
Jul 3, 2020
Merged

cyclic, cmd: qoute cyclic table name, fatal if loopback and fix a data race #701

merged 8 commits into from
Jul 3, 2020

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

  • Correct a few logs
  • Fix data race on log
  • Fail fast if loopback detected
  • Quote mark table name in update SQL.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the issue log may cause data race.

@overvenus
cyclic: qoute cyclic table name and fatal if replicate to self
c53ec89 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
cmd: fix logger data race
2d8e180 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus changed the title Cyclic/misc fix cyclic, cmd: qoute cyclic table name, fatal if loopback and fix a data race Jun 29, 2020
@overvenus
Copy link
Member Author

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #701 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #701   +/-   ##
===========================================
  Coverage   31.4206%   31.4206%           
===========================================
  Files            90         90           
  Lines          9411       9411           
===========================================
  Hits           2957       2957           
  Misses         6215       6215           
  Partials        239        239

zier-one
zier-one approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added the LGT1 label Jun 29, 2020
amyangfei
amyangfei reviewed Jul 1, 2020
View reviewed changes
tests/cyclic_loopback/run.sh
@@ -1,66 +0,0 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this test case removed?

@overvenus
cmd: refine cmd init
4267e3c 
Signed-off-by: Neil Shen <overvenus@gmail.com>
amyangfei
amyangfei approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT2 and removed LGT1 labels Jul 2, 2020
@amyangfei
Copy link
Contributor

/run-integration-tests

@overvenus
Copy link
Member Author

/run-integration-tests

@amyangfei amyangfei merged commit 0057782 into pingcap:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @codecov-commenter @amyangfei @zier-one