Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: support update changefeed config, in non-online way #699

Merged
merged 6 commits into from
Jul 1, 2020
Merged

cmd: support update changefeed config, in non-online way #699

merged 6 commits into from
Jul 1, 2020

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

This is the first part of #560

What is changed and how it works?

Add a changefeed update command in cdc cli

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@amyangfei amyangfei added subject/usability Denotes an issue or pull request is related to usability. status/WIP labels Jun 28, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2020 •
edited
Loading

Codecov Report

Merging #699 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #699   +/-   ##
===========================================
  Coverage   31.4360%   31.4360%           
===========================================
  Files            90         90           
  Lines          9206       9206           
===========================================
  Hits           2894       2894           
  Misses         6074       6074           
  Partials        238        238

@amyangfei amyangfei added status/ptal Could you please take a look? and removed status/WIP labels Jun 28, 2020
overvenus
overvenus approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus overvenus added the LGT1 label Jun 29, 2020
@amyangfei
Copy link
Contributor Author

/rebuild

@amyangfei
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added this to the v4.0.3 milestone Jul 1, 2020
zier-one
zier-one approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added LGT2 and removed LGT1 labels Jul 1, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

2 similar comments
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei merged commit f1ec399 into pingcap:master Jul 1, 2020
@amyangfei amyangfei deleted the update-changefeed branch July 1, 2020 08:04
@amyangfei amyangfei mentioned this pull request Jul 10, 2020
Closed
2 tasks
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
@amyangfei
cmd: support update changefeed config, in non-online way (pingcap#699)
ada076b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
status/ptal Could you please take a look? subject/usability Denotes an issue or pull request is related to usability.
Projects
None yet
Milestone
v4.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@amyangfei @codecov-commenter @overvenus @zier-one