*: replace capture ID with address in metrics #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus
added
the
subject/usability
|
/run-integration-tests |
overvenus
commented
Jun 23, 2020
Comment on lines
+2
to
+12
| "__inputs": [ | ||
| { | ||
| "name": "DS_TEST-CLUSTER", | ||
| "label": "test-cluster", | ||
| "description": "", | ||
| "type": "datasource", | ||
| "pluginId": "prometheus", | ||
| "pluginName": "Prometheus" | ||
| } | ||
| ], | ||
| "__requires": [ |
There was a problem hiding this comment.
I add these two back, are they compatible with tiup? @lichunzhu
There was a problem hiding this comment.
I think they are compatible with tiup. @overvenus
Signed-off-by: Neil Shen <overvenus@gmail.com>
zier-one
reviewed
Jun 23, 2020
Co-authored-by: leoppro <i@leop.pro>
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
amyangfei
reviewed
Jun 24, 2020
amyangfei
reviewed
Jun 24, 2020
Co-authored-by: amyangfei <amyangfei@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
================================================
- Coverage 32.1609% 31.6450% -0.5160%
================================================
Files 89 90 +1
Lines 8899 9082 +183
================================================
+ Hits 2862 2874 +12
- Misses 5801 5972 +171
Partials 236 236 |
|
/merge |
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
* metrics: refine grafan dashboard * *: replace capture ID with address in metrics * sink: sanitize kafka name * Update scripts/check-copyright.sh * use 127.0.0.1 in tests Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Replace capture ID with address in metrics
Check List
Tests
Code changes
Related changes
Release note