Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relay(dm): cancel when relay meet error to close goroutine #6803

Merged
merged 5 commits into from
Aug 19, 2022
Merged

relay(dm): cancel when relay meet error to close goroutine #6803

merged 5 commits into from
Aug 19, 2022

Conversation

lance6716
Copy link
Contributor

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: close #6193

What is changed and how it works?

as title

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Fix a bug that relay goroutine and upstream connections may leak when relay meet error

@lance6716
relay(dm): cancel when relay meet error to close goroutine
b593667 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • buchuitoudegou

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-2.0.5 needs-cherry-pick-release-2.0.6 needs-cherry-pick-release-2.0.7 needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Aug 19, 2022
@lance6716
fix lint
635418a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2022
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @D3Hunter @buchuitoudegou

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2022
buchuitoudegou
buchuitoudegou approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@buchuitoudegou buchuitoudegou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

dm/tests/new_relay/run.sh Outdated
echo "relay goroutine leak detected, count expect 1 but got $count"
exit 1
fi
echo ">>>>>>>>>>>>>>>>>>>>>>>>>>test test_cant_dail_upstream passed"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_cant_dail_upstream? Is it another test?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 19, 2022
lance6716
lance6716 commented Aug 19, 2022
View reviewed changes
dm/tests/new_relay/run.sh Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-2.0.7 needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. labels Aug 19, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0746319

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 19, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit a9b5c0b into pingcap:master Aug 19, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 19, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6811.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 19, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6812.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 19, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6813.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 19, 2022
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#6803
86cf952 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 19, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6814.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 19, 2022
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#6803
c1817b5 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout release-2.0.5: error checking out release-2.0.5: exit status 1. output: error: pathspec 'release-2.0.5' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout release-2.0.6: error checking out release-2.0.6: exit status 1. output: error: pathspec 'release-2.0.6' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout release-2.0.7: error checking out release-2.0.7: exit status 1. output: error: pathspec 'release-2.0.7' did not match any file(s) known to git

ti-chi-bot added a commit that referenced this pull request Aug 19, 2022
@ti-chi-bot
relay(dm): cancel when relay meet error to close goroutine (#6803) (#…
147051d 
…6812)

close #6193
ti-chi-bot added a commit that referenced this pull request Aug 22, 2022
@ti-chi-bot
relay(dm): cancel when relay meet error to close goroutine (#6803) (#…
82a688e 
…6813)

close #6193
ti-chi-bot added a commit that referenced this pull request Aug 23, 2022
@ti-chi-bot
relay(dm): cancel when relay meet error to close goroutine (#6803) (#…
246e1d8 
…6814)

close #6193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-2.0.5 needs-cherry-pick-release-2.0.6 needs-cherry-pick-release-2.0.7 needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gorouting & connection leak when relay meet error
4 participants
@lance6716 @ti-chi-bot @D3Hunter @buchuitoudegou