Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: quote schema.table to avoid error in SQL syntax #676

Merged
merged 3 commits into from
Jun 22, 2020
Merged

pkg: quote schema.table to avoid error in SQL syntax #676

merged 3 commits into from
Jun 22, 2020

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Fix the error when creating mark table with invalid characters.

fail to create mark table repl_mark_test_dm_meta_sg-test_syncer_checkpoint: 
  Error 1064: You have an error in your SQL syntax; 
    check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 62 near "-test_syncer_checkpoint

What is changed and how it works?

Should quote schema and table

Check List

Tests

  • Integration test

Release note

  • No release note

@amyangfei amyangfei changed the title pkg: quote schema.table to avoid error in your SQL syntax pkg: quote schema.table to avoid error in SQL syntax Jun 20, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #676 into master will decrease coverage by 0.1863%.
The diff coverage is 0.0000%.

@@               Coverage Diff                @@
##             master       #676        +/-   ##
================================================
- Coverage   32.5293%   32.3429%   -0.1864%     
================================================
  Files            88         88                
  Lines          8872       8852        -20     
================================================
- Hits           2886       2863        -23     
- Misses         5751       5753         +2     
- Partials        235        236         +1

@amyangfei amyangfei added status/ptal Could you please take a look? bug-from-poc labels Jun 20, 2020
overvenus
overvenus approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT1 and removed status/ptal Could you please take a look? labels Jun 22, 2020
zier-one
zier-one approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added LGT2 and removed LGT1 labels Jun 22, 2020
@amyangfei amyangfei merged commit 2a26bc9 into pingcap:master Jun 22, 2020
@amyangfei amyangfei deleted the fix-create-mark-table branch June 22, 2020 04:18
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
@amyangfei
pkg: quote schema.table to avoid error in SQL syntax (pingcap#676)
ba0b49f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amyangfei @codecov-commenter @overvenus @zier-one