Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ticdc): fix incompatible configuration of transaction-atomicity #6166

Merged
merged 5 commits into from
Jul 4, 2022

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Jul 4, 2022

What problem does this PR solve?

Issue Number: ref #5231

What is changed and how it works?

Fix incompatible configuration of transaction-atomicity in swagger.

Check List

Tests

  • No code
`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 4, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2022
@CharlesCheung96 CharlesCheung96 changed the title docsfix swagger docs(ticdc): fix swagger Jul 4, 2022
@CharlesCheung96 CharlesCheung96 changed the title docs(ticdc): fix swagger docs(ticdc): fix incompatible configuration of transaction-atomicity Jul 4, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 4, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 4, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 4, 2022
@liuzix
Copy link
Contributor

liuzix commented Jul 4, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: afae4e5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 4, 2022
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-verify
/run-integration-test

@CharlesCheung96
Copy link
Contributor Author

/run-verify

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #6166 (d410d0c) into master (ef587e6) will decrease coverage by 0.4511%.
The diff coverage is 68.3491%.

❗ Current head d410d0c differs from pull request most recent head 1ac6627. Consider uploading reports for the commit 1ac6627 to get more accurate results

Flag Coverage Δ
cdc 63.6077% <67.0958%> (-1.0770%) ⬇️
dm 51.9625% <64.1509%> (+0.0733%) ⬆️
engine 62.7302% <73.8693%> (+0.1963%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6166        +/-   ##
================================================
- Coverage   58.4193%   57.9681%   -0.4512%     
================================================
  Files           711        701        -10     
  Lines         84205      83156      -1049     
================================================
- Hits          49192      48204       -988     
- Misses        30540      30602        +62     
+ Partials       4473       4350       -123     

@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 2af3205 into pingcap:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants