Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: a new table migration mechanism #572

Merged
merged 4 commits into from
May 18, 2020
Merged

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented May 14, 2020

What problem does this PR solve?

  • Unify the variable types of tableID
  • Deprecated the table lock and using undo list(Operation in TaskStatus) to maintain table migration
  • support to add or remove more than one tables in one tick

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@zier-one
Copy link
Contributor Author

/run-integration-tests

3 similar comments
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one zier-one changed the title new lock *: a new table migration mechanism May 14, 2020
cdc/changefeed.go Show resolved Hide resolved
cdc/model/owner.go Outdated Show resolved Hide resolved
@zier-one
Copy link
Contributor Author

/run-integration-tests

2 similar comments
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

Merging #572 into master will increase coverage by 0.7616%.
The diff coverage is 8.8983%.

@@               Coverage Diff                @@
##             master       #572        +/-   ##
================================================
+ Coverage   30.8896%   31.6513%   +0.7616%     
================================================
  Files            71         69         -2     
  Lines          7857       6837      -1020     
================================================
- Hits           2427       2164       -263     
+ Misses         5265       4517       -748     
+ Partials        165        156         -9     

@zier-one
Copy link
Contributor Author

/run-integration-tests

8 similar comments
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one zier-one marked this pull request as ready for review May 15, 2020 06:47
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one zier-one added the status/ptal Could you please take a look? label May 15, 2020
@zier-one
Copy link
Contributor Author

/run-integration-tests

2 similar comments
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@amyangfei
Copy link
Contributor

Remember to remove debug log

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@zier-one
Copy link
Contributor Author

/run-integration-tests

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added component/scheduler TiCDC inner scheduler component. LGT1 priority/P0 The issue has P0 priority. component/replica-model Replication model component. and removed status/ptal Could you please take a look? component/scheduler TiCDC inner scheduler component. labels May 18, 2020
@zier-one zier-one merged commit 2c8a7e2 into pingcap:master May 18, 2020
@zier-one zier-one deleted the new_lock branch May 18, 2020 11:18
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/replica-model Replication model component. priority/P0 The issue has P0 priority.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants