Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port schema bugfix from binlog #56

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Port schema bugfix from binlog #56

merged 1 commit into from
Oct 17, 2019

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Oct 17, 2019

@suzaku suzaku added the status/ptal Could you please take a look? label Oct 17, 2019
@zier-one
Copy link
Contributor

/run-all-tests

zier-one
zier-one reviewed Oct 17, 2019
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amyangfei
amyangfei approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku suzaku merged commit 039f8d3 into pingcap:master Oct 17, 2019
@suzaku suzaku deleted the fix-schema branch October 17, 2019 06:28
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
@suzaku
Port schema bugfix from binlog (pingcap#56)
8ce2dd3
amyangfei added a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
@amyangfei
master: support forward rpc to server master leader (pingcap#56)
b3357b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one left review comments

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suzaku @zier-one @amyangfei