kvclient: support resolve lock for ticdc #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zier-one
added
status/ptal
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
================================================
+ Coverage 29.2417% 29.3461% +0.1044%
================================================
Files 59 58 -1
Lines 5328 5827 +499
================================================
+ Hits 1558 1710 +152
- Misses 3629 4000 +371
+ Partials 141 117 -24 |
|
/run-all-tests |
|
/run-all-tests |
|
/run-integration-tests |
3 similar comments
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
2 similar comments
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-all-tests |
MyonKeminta
reviewed
Apr 15, 2020
|
/run-all-tests |
|
/run-kafka-tests |
|
By the way I think it would be good if there can be a test that checks the resolve lock won't kill an ongoing transaction.. |
|
/run-all-tests |
|
/run-all-tests |
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
support resolve lock for ticdc
What is changed and how it works?
Check List
Tests