owner: fix a bug about wrong timing sequence of DDL when add a table to processor #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
April 9, 2020 23:45
zier-one
changed the title
|
/run-all-tests |
|
/run-all-tests |
amyangfei
reviewed
Apr 10, 2020
cdc/changefeed.go
Outdated
Comment on lines
536
to
537
| c.status.ResolvedTs = minResolvedTs | ||
| c.status.CheckpointTs = minCheckpointTs |
There was a problem hiding this comment.
these two lines have conflict with L541 and L545. c.sink.EmitCheckpointEvent will be never called?
|
/run-all-tests |
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix a bug about wrong timing sequence of DDL when add a table to processor
What is changed and how it works?
when the owner add a table to a processor, the owner should ensure the global resolvedts won't exceed the startts of the new table
Check List
Tests