-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loader(dm): register tls config when clean checkpoint #3522
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-dm-integration-tests |
/run-dm-integration-tests |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #3522 +/- ##
================================================
+ Coverage 57.3452% 57.8036% +0.4584%
================================================
Files 460 465 +5
Lines 54927 55538 +611
================================================
+ Hits 31498 32103 +605
+ Misses 20180 20150 -30
- Partials 3249 3285 +36 |
if err = cfg.Adjust(ctx); err != nil { | ||
return err | ||
} | ||
err = l.runLightning(ctx, cfg) | ||
if err == nil { | ||
// lightning will auto deregister tls when task done, so we need to register it again for removing checkpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might let lightning not deregister the certificate. If there're more than one subtasks, the certificate may still be deregister between line 245 and line 249
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now lightning allow register tls config with different name, and it test is passed, ptal 🧡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CheckpointRemove should be postponed to cleanmeta. I will add this logic in a following PR, so LGTM.
/hold need change lightning behaviour and upgrade dep |
dm/loader/lightning.go
Outdated
lightningCfg.TikvImporter.Backend = cfg.TiDB.Backend | ||
lightningCfg.PostRestore.Checksum = lcfg.OpLevelOff | ||
if cfg.TiDB.Backend == lcfg.BackendLocal { | ||
lightningCfg.TikvImporter.SortedKVDir = cfg.Dir | ||
} | ||
lightningCfg.Mydumper.SourceDir = cfg.Dir | ||
lightningCfg.App.Config.Level = cfg.LogLevel | ||
lightningCfg.App.Config.File = cfg.LogFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should net let lightning init log another time. pingcap/tidb#29291 this PR will skip init lightning log so lightning will share the global config with dm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed ptal
/run-all-tests |
/run-all-tests |
/run-dm-integration-tests |
/run-dm-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
/merge |
This pull request has been accepted and is ready to merge. Commit hash: fa145d0
|
@Ehco1996: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-integration-test |
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note