Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test case to cover varchar default value (#2799) #2895

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2799

What problem does this PR solve?

Add test case to cover #2758

What is changed and how it works?

The case works as follows

  • create a table, executing DML of this table in background
  • alter table add column v1 varchar(20) default "xxx" not null
  • Some of the DMLs could have no field of v1, however when we decode these rows, we should use the new table schema (which has the column of v1, this scenario doesn't break the constraint of online DDL). Since the column doesn't exist, the tidb library will fill in a default value, which is a string type here. This is why we can get either []byte or a string of a column.Value.

Check List

Tests

  • Unit test
  • Integration test

Release note

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. component/test Unit tests and integration tests component. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Sep 25, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 26, 2021
@amyangfei amyangfei added this to the v5.2.2 milestone Sep 27, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 071042c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@d8100bc). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.2      #2895   +/-   ##
================================================
  Coverage               ?   55.5345%           
================================================
  Files                  ?        185           
  Lines                  ?      20607           
  Branches               ?          0           
================================================
  Hits                   ?      11444           
  Misses                 ?       8088           
  Partials               ?       1075           

@ti-chi-bot ti-chi-bot merged commit 43fe094 into pingcap:release-5.2 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants