-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix dml not replicate when add partition about partition table without valid index #2841
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @erwadba! |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 421ce75
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Unit test or integration test will be added in another PR, followed up in #2834 (comment) |
/merge |
@erwadba: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## master #2841 +/- ##
================================================
+ Coverage 55.3406% 58.9558% +3.6151%
================================================
Files 164 180 +16
Lines 19754 18580 -1174
================================================
+ Hits 10932 10954 +22
+ Misses 7790 6633 -1157
+ Partials 1032 993 -39 |
In response to a cherrypick label: new pull request created: #2863. |
In response to a cherrypick label: new pull request created: #2864. |
In response to a cherrypick label: new pull request created: #2865. |
In response to a cherrypick label: new pull request created: #2866. |
What problem does this PR solve?
#2834
When
force-replicate
is enabled. Add partition on partition table without valid index. The cdc will stop dml replication about the partition table without errors and warnings.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note