Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix dml not replicate when add partition about partition table without valid index #2841

Merged
merged 4 commits into from
Sep 22, 2021

Conversation

erwadba
Copy link
Contributor

@erwadba erwadba commented Sep 16, 2021

What problem does this PR solve?

#2834
When force-replicate is enabled. Add partition on partition table without valid index. The cdc will stop dml replication about the partition table without errors and warnings.

What is changed and how it works?

Check List

Tests

  • N/A

Code changes

  • N/A

Side effects

  • N/A

Related changes

  • N/A

Release note

Fix dml is not replicated after adding partition in partition table without valid index

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 16, 2021
@CLAassistant
Copy link

CLAassistant commented Sep 16, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Sep 16, 2021
@ti-chi-bot
Copy link
Member

Welcome @erwadba!

It looks like this is your first PR to pingcap/ticdc 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/ticdc. 😃

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 16, 2021
@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Sep 16, 2021
@amyangfei amyangfei added this to the v5.3.0 milestone Sep 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 421ce75

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@amyangfei
Copy link
Contributor

Unit test or integration test will be added in another PR, followed up in #2834 (comment)

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 18, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@erwadba: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

Codecov Report

Merging #2841 (fdcc0bc) into master (11e574c) will increase coverage by 3.6151%.
The diff coverage is 55.0187%.

@@               Coverage Diff                @@
##             master      #2841        +/-   ##
================================================
+ Coverage   55.3406%   58.9558%   +3.6151%     
================================================
  Files           164        180        +16     
  Lines         19754      18580      -1174     
================================================
+ Hits          10932      10954        +22     
+ Misses         7790       6633      -1157     
+ Partials       1032        993        -39     

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2863.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2864.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2865.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2866.

ti-chi-bot added a commit that referenced this pull request Sep 23, 2021
ti-chi-bot added a commit that referenced this pull request Sep 23, 2021
ti-chi-bot added a commit that referenced this pull request Sep 23, 2021
ti-chi-bot added a commit that referenced this pull request Sep 24, 2021
@erwadba erwadba deleted the fix_add_partition branch September 2, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants