redolog : redolog storage layer data model & common util #2809
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
the
release-note-none
ti-chi-bot
added
the
size/XXL
| // InitS3storage init a storage used for s3, | ||
| // s3URI should be like s3URI="s3://logbucket/test-changefeed?endpoint=http://$S3_ENDPOINT/" | ||
| func InitS3storage(ctx context.Context, s3URI url.URL) (storage.ExternalStorage, error) { | ||
| if len(s3URI.Host) == 0 { |
There was a problem hiding this comment.
Do we need to check its protocol?
| // fmt.Sprintf("%s_%s_%d_%s_%d%s", w.cfg.captureID, w.cfg.changeFeedID, w.cfg.createTime.Unix(), w.cfg.fileType, w.commitTS.Load(), LogEXT)+SortLogEXT | ||
| if ext == SortLogEXT { | ||
| name = strings.TrimSuffix(name, SortLogEXT) | ||
| ext = filepath.Ext(name) |
There was a problem hiding this comment.
This should be the ext of the log file, maybe we could call it logExt for clarity?
| } | ||
|
|
||
| // if .sort, the name should be like | ||
| // fmt.Sprintf("%s_%s_%d_%s_%d%s", w.cfg.captureID, w.cfg.changeFeedID, w.cfg.createTime.Unix(), w.cfg.fileType, w.commitTS.Load(), LogEXT)+SortLogEXT |
There was a problem hiding this comment.
It would be nice to add a real example!
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: fa8fcd7
|
ti-chi-bot
added
the
status/can-merge
|
/run-kafka-tests |
|
/run-all-tests |
|
@ben1009: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-kafka-tests |
What problem does this PR solve?
#2351 redo log based replication to implement eventually consistency
#2685 contains all of the change for the requirement, will split into small ones for review, this is one of the prs, split from the #2685
What is changed and how it works?
this one contains basic data model, common util used in the fellowing PRs
Check List
Tests
Code changes
Side effects
Related changes
Release note