Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puller: clean up unused parameter (#2309) #2324

Merged
merged 3 commits into from
Jul 21, 2021
Merged

puller: clean up unused parameter (#2309) #2324

merged 3 commits into from
Jul 21, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2309

What problem does this PR solve?

Follow up #2271

What is changed and how it works?

clean up unused parameter.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#2309
b18da3b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Jul 19, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 19, 2021
Merged
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 19, 2021
@amyangfei
Copy link
Contributor

amyangfei commented Jul 19, 2021 •
edited
Loading

merge this PR after #2306 is merged

@amyangfei amyangfei added this to the v5.1.1 milestone Jul 19, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2021
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 21, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 8e36a03

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2021
@amyangfei
Copy link
Contributor

/run-leak-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@Rustin170506
Copy link
Member

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.1@812a614). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.1      #2324   +/-   ##
================================================
  Coverage               ?   57.0604%           
================================================
  Files                  ?        165           
  Lines                  ?      19425           
  Branches               ?          0           
================================================
  Hits                   ?      11084           
  Misses                 ?       7283           
  Partials               ?       1058

@ti-chi-bot ti-chi-bot merged commit 07a5761 into pingcap:release-5.1 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one Awaiting requested review from zier-one

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@Rustin170506 Rustin170506

Labels
cherry-pick-approved Cherry pick PR approved by release team. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @amyangfei @Rustin170506 @codecov-commenter @lonng