Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/client: add incremental scan region count limit #1981

Merged
merged 4 commits into from
Jun 8, 2021
Merged

kv/client: add incremental scan region count limit #1981

merged 4 commits into from
Jun 8, 2021

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

cherry-pick #1899 into release-5.0

What is changed and how it works?

cherry-pick #1899 into release-5.0

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Add concurrency limit to the region incremental scan in kv client.

@amyangfei amyangfei added the type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. label Jun 8, 2021
@amyangfei amyangfei added this to the v5.0.2 milestone Jun 8, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 8, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-integration-tests
/run-kafka-tests

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor Author

/run-all-tests /tidb=release-5.0 /tikv=release-5.0 /pd=release-5.0 /tiflash=release-5.0

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@2941eb3). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #1981   +/-   ##
================================================
  Coverage               ?   54.0478%           
================================================
  Files                  ?        156           
  Lines                  ?      16589           
  Branches               ?          0           
================================================
  Hits                   ?       8966           
  Misses                 ?       6671           
  Partials               ?        952

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leoppro
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 8, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 8, 2021
@lonng
Copy link
Contributor

lonng commented Jun 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d12bc1b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests /tidb=release-5.0 /tikv=release-5.0 /pd=release-5.0 /tiflash=release-5.0

@ti-chi-bot ti-chi-bot merged commit b6d58ef into pingcap:release-5.0 Jun 8, 2021
@amyangfei amyangfei deleted the cherry-pick-5.0-region-scan-limit branch June 8, 2021 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
6 participants
@amyangfei @codecov-commenter @ti-chi-bot @lonng @overvenus @zier-one