Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv/client: add incremental scan region count limit (#1899) #1930

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1899

What problem does this PR solve?

This PR adds a token limiter to kv client, in order to control the concurrency of incremental scan region, for some reasons:

  • A large scale incremental scan tasks could cause pressure in TiKV server, which could lead to OOM in TiKV.
  • TiKV could also add concurrency limit of incremental scan regions and prevents too much memory consumption, however it will cause too many uninitialized pending regions in TiCDC kv clients. Region reconnect could happen before the TiKV can serve them.

What is changed and how it works?

  • Add a token based region router.
    • When the used token doesn't reach upper limit, redirect the region request as soon as possible.
    • Otherwise buffer the region request, and check 100ms to see whether there exists new token opportunity.
    • The token is grouped by store address
  • Separate some logic from dispatchRequest into requestRegionToStore
    • dispatchRequest only reads singleRegionInfo from region channel, try to get gRPC context and sends the singleRegionInfo(which has been filled in with gRPC context) into region router
    • requestRegionToStore reads singleRegionInfo from the output channel of region based region router, and sends real gRPC request to TiKV store.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

  • Add concurrency limit to the region incremental scan in kv client.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved component/kv-client TiKV kv log client component. status/ptal Could you please take a look? size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jun 4, 2021
@ti-chi-bot ti-chi-bot requested a review from zier-one June 4, 2021 02:09
@ti-chi-bot ti-chi-bot requested a review from amyangfei June 4, 2021 02:09
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2021
@lonng lonng added this to the v4.0.14 milestone Jun 10, 2021
@amyangfei
Copy link
Contributor

Cherry-picked in #2149

@amyangfei amyangfei closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/kv-client TiKV kv log client component. do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/ptal Could you please take a look? type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants