tests: fix leak test in embeded etcd test

[amyangfei]

What problem does this PR solve?

Fix a leak in test from CI

[2021-06-02T11:43:34.661Z] ----------------------------------------------------------------------
[2021-06-02T11:43:34.661Z] FAIL: etcd_test.go:53: etcdSuite.TestEmbedEtcd
[2021-06-02T11:43:34.661Z] 
[2021-06-02T11:43:34.661Z] etcd_test.go:74:
[2021-06-02T11:43:34.661Z]     ...
[2021-06-02T11:43:34.661Z] /home/jenkins/agent/workspace/cdc_ghpr_leak_test/go/src/github.com/pingcap/ticdc/pkg/util/testleak/leaktest.go:162:
[2021-06-02T11:43:34.661Z]     c.Errorf("Test %s check-count %d appears to have leaked: %v", c.TestName(), cnt, g)
[2021-06-02T11:43:34.661Z] ... Error: Test etcdSuite.TestEmbedEtcd check-count 50 appears to have leaked: github.com/pingcap/ticdc/pkg/etcd.(*etcdSuite).SetUpTest.func1(0xc00022a4b0, 0xc00003f080)
[2021-06-02T11:43:34.661Z] 	/home/jenkins/agent/workspace/cdc_ghpr_leak_test/go/src/github.com/pingcap/ticdc/pkg/etcd/etcd_test.go:45 +0x6d
[2021-06-02T11:43:34.661Z] created by github.com/pingcap/ticdc/pkg/etcd.(*etcdSuite).SetUpTest
[2021-06-02T11:43:34.661Z] 	/home/jenkins/agent/workspace/cdc_ghpr_leak_test/go/src/github.com/pingcap/ticdc/pkg/etcd/etcd_test.go:44 +0x172
[2021-06-02T11:43:34.661Z] 
[2021-06-02T11:43:34.661Z] OOPS: 4 passed, 1 FAILED
[2021-06-02T11:43:34.661Z] --- FAIL: Test (28.03s)
[2021-06-02T11:43:34.661Z] FAIL
[2021-06-02T11:43:34.661Z] FAIL	github.com/pingcap/ticdc/pkg/etcd	28.104s

What is changed and how it works?

Remove the log error goroutine, log error when test shutdown

Check List

Tests

• Unit test
• Integration test

Release note

• No release note

[amyangfei]

/run-all-tests

[amyangfei]

/run-leak-tests

[ti-chi-bot]

@ben1009: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• leoppro
• overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[overvenus]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: e00afc9

[zier-one]

/merge

[zier-one]

/run-all-tests

[zier-one]

/run-integration-tests

[codecov-commenter]

Codecov Report

Merging #1916 (183344c) into master (a1067a0) will increase coverage by 0.3891%.
The diff coverage is 67.3134%.

@@               Coverage Diff                @@
##             master      #1916        +/-   ##
================================================
+ Coverage   53.8503%   54.2395%   +0.3891%     
================================================
  Files           155        163         +8     
  Lines         16479      17325       +846     
================================================
+ Hits           8874       9397       +523     
- Misses         6655       6921       +266     
- Partials        950       1007        +57     

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #1943.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #1944.