Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: update TiKV metrics #1752

Merged
merged 2 commits into from
May 12, 2021
Merged

metrics: update TiKV metrics #1752

merged 2 commits into from
May 12, 2021

Conversation

overvenus
Copy link
Member

@overvenus overvenus commented May 10, 2021 •
edited
Loading

What problem does this PR solve?

Update TiKV graphs to display recently added metrics.

image
image
image

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

  • No release note

@overvenus
metrics: update TiKV metrics
20afedb 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. component/metrics-logging Metrics and logging component. labels May 10, 2021
@overvenus overvenus added this to the v4.0.13 milestone May 10, 2021
@ti-chi-bot ti-chi-bot requested a review from amyangfei May 10, 2021 06:24
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 10, 2021
@overvenus overvenus mentioned this pull request May 10, 2021
Closed
5 tasks
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2021
@ben1009
Copy link
Contributor

ben1009 commented May 12, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@ben1009: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zier-one
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • leoppro

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2021
@zier-one
Copy link
Contributor

please remember to update metrics docs @overvenus

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 20afedb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2021
@amyangfei
Copy link
Contributor

/run-unit-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

2 similar comments
@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #1752 (93c6ca8) into master (86d4301) will decrease coverage by 1.1525%.
The diff coverage is 90.4761%.

@@               Coverage Diff                @@
##             master      #1752        +/-   ##
================================================
- Coverage   54.0130%   52.8604%   -1.1526%     
================================================
  Files           155        153         -2     
  Lines         16459      15889       -570     
================================================
- Hits           8890       8399       -491     
+ Misses         6630       6581        -49     
+ Partials        939        909        -30

@ti-chi-bot ti-chi-bot merged commit f1ad63b into pingcap:master May 12, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 12, 2021
@overvenus @ti-chi-bot
This is an automated cherry-pick of pingcap#1752
686ce6f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1767.

@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2021
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1768.

ti-chi-bot added a commit that referenced this pull request May 13, 2021
@ti-chi-bot
metrics: update TiKV metrics (#1752) (#1767)
c08d59e
ti-chi-bot added a commit that referenced this pull request May 27, 2021
@ti-chi-bot
metrics: update TiKV metrics (#1752) (#1768)
1c299a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
component/metrics-logging Metrics and logging component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v4.0.13
Development

Successfully merging this pull request may close these issues.
6 participants
@overvenus @ben1009 @ti-chi-bot @zier-one @amyangfei @codecov-commenter