-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "sink/mysql: explicit_defaults_for_timestamp compatibility with mysql (#1638)" (#1743) #1749
Revert "sink/mysql: explicit_defaults_for_timestamp compatibility with mysql (#1638)" (#1743) #1749
Conversation
…h mysql (pingcap#1638)" This reverts commit 6d4d4e4.
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d81abd1
|
/run-all-tests |
/run-unit-tests |
/run-integration-tests |
/run-unit-tests |
1 similar comment
/run-unit-tests |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-leak-tests |
1 similar comment
/run-leak-tests |
/run-integration-tests |
/run-leak-tests |
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1749 +/- ##
===================================================
- Coverage 53.7661% 52.7706% -0.9955%
===================================================
Files 153 151 -2
Lines 15958 15592 -366
===================================================
- Hits 8580 8228 -352
- Misses 6475 6480 +5
+ Partials 903 884 -19 |
This is an automated cherry-pick of #1743
What problem does this PR solve?
This reverts commit 6d4d4e4.
Since even set session variable
explicit_defaults_for_timestamp
in MySQL 5.7 requires theSUPER
privilege, which blocks many usage scenarios.What is changed and how it works?
revert #1638, user should pay attention to the
explicit_defaults_for_timestamp
config when they replicate data from to MySQL 5.7.Check List
Tests
Release note
SUPER
privilege when replicating to MySQL.