Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "sink/mysql: explicit_defaults_for_timestamp compatibility with mysql (#1638)" (#1743) #1749

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1743

What problem does this PR solve?

This reverts commit 6d4d4e4.

Since even set session variable explicit_defaults_for_timestamp in MySQL 5.7 requires the SUPER privilege, which blocks many usage scenarios.

What is changed and how it works?

revert #1638, user should pay attention to the explicit_defaults_for_timestamp config when they replicate data from to MySQL 5.7.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Revert the update for explicit_defaults_for_timestamp which requires SUPER privilege when replicating to MySQL.

@ti-chi-bot ti-chi-bot added status/ptal Could you please take a look? size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2021
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. label May 9, 2021
@ti-chi-bot ti-chi-bot requested a review from overvenus May 9, 2021 03:55
@ti-chi-bot ti-chi-bot requested review from amyangfei and zier-one May 9, 2021 03:55
@amyangfei amyangfei added this to the v4.0.13 milestone May 9, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2021
@liuzix
Copy link
Contributor

liuzix commented May 9, 2021

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 9, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 11, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: d81abd1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2021
@amyangfei
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/run-unit-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-unit-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-unit-tests

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-leak-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-leak-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-leak-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #1749 (9b8e634) into release-4.0 (753073a) will decrease coverage by 0.9954%.
The diff coverage is 69.0789%.

@@                 Coverage Diff                 @@
##           release-4.0      #1749        +/-   ##
===================================================
- Coverage      53.7661%   52.7706%   -0.9955%     
===================================================
  Files              153        151         -2     
  Lines            15958      15592       -366     
===================================================
- Hits              8580       8228       -352     
- Misses            6475       6480         +5     
+ Partials           903        884        -19     

@ti-chi-bot ti-chi-bot merged commit 94b1614 into pingcap:release-4.0 May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants