Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink/mysql: rollback txn to recycle db conn, refine timeout param in db conn (#1279) #1285

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1279 to release-4.0

What problem does this PR solve?

Fix bug in #1261 & #1275

What is changed and how it works?

Besides, this PR doesn't introduce any timeout context to control database operation, since at current stage, TiCDC doesn't need to have an accurate running time limit for database operation.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
    • add read-timeout, write-timeout and timeout in sink uri parameters

Release note

  • Fix a bug that MySQL connection is not recycled when some transactions executed with failure.
  • Fix a bug that MySQL sink could hang if downstream TiDB/MySQL is not available.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@amyangfei
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 7, 2021
@amyangfei amyangfei added this to the v4.0.10 milestone Jan 7, 2021
@zier-one
Copy link
Contributor

zier-one commented Jan 7, 2021

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 7, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 7, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@liuzix
Copy link
Contributor

liuzix commented Jan 7, 2021

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jan 7, 2021
@ti-srebot ti-srebot merged commit bced60a into pingcap:release-4.0 Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants