Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple (ticdc): support send all tables bootstrap message at changefeed start (#11239) #11400

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11239

What problem does this PR solve?

Issue Number: close #11315

What is changed and how it works?

A boolean parameter send-all-bootstrap-at-start is added, which is set to false by default.
If this parameter is set to true, the changefeed, upon starting, will send the schema of all synchronized tables downstream as Bootstrap events. This will be done synchronously in the ddlSink. After the Bootstrap events are synchronized, row changes will begin to be synchronized.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jul 10, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 10, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2024
Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 18, 2024
@asddongmen
Copy link
Contributor

/retest

2 similar comments
@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

1 similar comment
@asddongmen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 23, 2024
@asddongmen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 23, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jul 23, 2024
@asddongmen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit b00c3ee into pingcap:release-7.5 Jul 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants