Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(dm): move column-mapping from tidb-tools to tiflow repo #11112

Merged
merged 3 commits into from
May 16, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented May 16, 2024

What problem does this PR solve?

Issue Number: close #11114

What is changed and how it works?

column-mapping is a dead package, we won't develop its feature in future, so the duplication of code with tidb-tools is fine because the code will not change.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 16, 2024
@3AceShowHand
Copy link
Contributor

please create new issue for each PR, this makes the cherry-pick process easier.

Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/check-issue-triage-complete

Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/retest

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 66.97248% with 108 lines in your changes are missing coverage. Please review.

Project coverage is 57.5742%. Comparing base (aed7768) to head (3e30fc2).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.9940% <66.9724%> (+0.0400%) ⬆️
dm 51.2349% <ø> (-0.0102%) ⬇️
engine 63.4161% <ø> (+0.0070%) ⬆️
Flag Coverage Δ
unit 57.5742% <66.9724%> (+0.0276%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11112        +/-   ##
================================================
+ Coverage   57.5466%   57.5742%   +0.0276%     
================================================
  Files           853        854         +1     
  Lines        125679     126006       +327     
================================================
+ Hits          72324      72547       +223     
- Misses        47986      48068        +82     
- Partials       5369       5391        +22     

@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 16, 2024
@3AceShowHand
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 16, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all code copied from tidb repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidb-tools. And the test files are changed to require package

Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-16 06:17:21.277902873 +0000 UTC m=+1720395.035038447: ☑️ agreed by 3AceShowHand.
  • 2024-05-16 06:31:13.101421022 +0000 UTC m=+1721226.858556580: ☑️ agreed by okJiang.

@lance6716
Copy link
Contributor Author

/approve

Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, lance6716, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 16, 2024
@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1c7c9ae into pingcap:master May 16, 2024
28 checks passed
@3AceShowHand 3AceShowHand added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 21, 2024
@3AceShowHand
Copy link
Contributor

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11153.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 21, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request could not be created: failed to create pull request against pingcap/tiflow#release-7.5 from head ti-chi-bot:cherry-pick-11112-to-release-7.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-11112-to-release-7.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 21, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 31, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 31, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11454.

@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move column-mapping from tidb-tools to tiflow repo
5 participants