Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add more unit tests in cdc/model package (#1081) #1105

Merged
merged 4 commits into from
Nov 20, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1081 to release-4.0


What problem does this PR solve?

Add more unit tests in cdc/model packages

What is changed and how it works?

This is part one, add unit tests for files excluding sink.go and schema_storage.go

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added status/ptal Could you please take a look? component/test Unit tests and integration tests component. type/4.0-cherry-pick labels Nov 19, 2020
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 19, 2020
@amyangfei
Copy link
Contributor

/run-all-tests

@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 19, 2020
@amyangfei
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/run-unit-tests

2 similar comments
@amyangfei
Copy link
Contributor

/run-unit-tests

@amyangfei
Copy link
Contributor

/run-unit-tests

@amyangfei amyangfei merged commit 8839931 into pingcap:release-4.0 Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Unit tests and integration tests component. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants