Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl_puller (ticdc): handle dorp pk/uk ddl correctly (#10965) #10984

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10965

What problem does this PR solve?

Issue Number: close #10890

What is changed and how it works?

When handling a DDL job in ddlPuller, check if it will transition the table from eligible to ineligible. If so, return an error and stop the changefeed. The error message should provide instructions for the user on how to manage the situation.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  1. Create a table t1.
CREATE TABLE t1 (
id INT PRIMARY KEY /*T![clustered_index] NONCLUSTERED */,
name VARCHAR(255),
email VARCHAR(255) UNIQUE
);
  1. Drop its primary key.
ALTER TABLE t1 DROP PRIMARY KEY; 
  1. List this changefeed.
-> # ./cdc cli changefeed list 
[
  {
    "id": "test",
    "namespace": "default",
    "summary": {
      "state": "warning",
      "tso": 449299724779651075,
      "checkpoint": "2024-04-24 15:07:11.563",
      "error": {
        "time": "2024-04-24T16:52:17.129593307+08:00",
        "addr": "127.0.0.1:8300",
        "code": "CDC:ErrProcessorUnknown",
        "message": "An eligible table become ineligible after DDL: [alter table t1 drop primary key] it is a dangerous operation. If you want to replicate this ddl, pelase pause the changefeed and update the `force-replicate=true` in the changefeed configuration, then resume the changefeed. Otherwise, will cause data loss."
      }
    }
  }
]
  1. Update the changefeed's config as the instructions in the error message and resume the changefeed. Check the CDC log to confirm if the DDL was replicated.
[2024/04/24 16:55:09.679 +08:00] [INFO] [ddl_manager.go:558] ["execute a ddl event successfully"] [ddl="ALTER TABLE `t1` DROP PRIMARY KEY"] [namespace=default] [changefeed=test] ....

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix a bug that might cause the replication of the 'drop primary key' or 'drop unique key' DDL to be lost.

Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 25, 2024
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 16 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@5e1b22e). Click here to learn what that means.

Additional details and impacted files
Components Coverage Δ
cdc 61.9151% <0.0000%> (?)
dm 51.2293% <0.0000%> (?)
engine 63.3879% <0.0000%> (?)
Flag Coverage Δ
unit 57.5073% <55.5555%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #10984   +/-   ##
================================================
  Coverage               ?   57.5073%           
================================================
  Files                  ?        849           
  Lines                  ?     125297           
  Branches               ?          0           
================================================
  Hits                   ?      72055           
  Misses                 ?      47847           
  Partials               ?       5395           

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 27, 2024
@asddongmen
Copy link
Contributor

/retest

3 similar comments
@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@asddongmen
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit d9b74fe into pingcap:release-8.1 Apr 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants