-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl_puller (ticdc): handle dorp pk/uk ddl correctly (#10965) #10984
ddl_puller (ticdc): handle dorp pk/uk ddl correctly (#10965) #10984
Conversation
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Signed-off-by: dongmen <414110582@qq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.1 #10984 +/- ##
================================================
Coverage ? 57.5073%
================================================
Files ? 849
Lines ? 125297
Branches ? 0
================================================
Hits ? 72055
Misses ? 47847
Partials ? 5395 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
This is an automated cherry-pick of #10965
What problem does this PR solve?
Issue Number: close #10890
What is changed and how it works?
When handling a DDL job in
ddlPuller
, check if it will transition the table from eligible to ineligible. If so, return an error and stop the changefeed. The error message should provide instructions for the user on how to manage the situation.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note