changefeed: fix goroutine leak when changefeed is paused or stopped (#1066) #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
type/bugfix
zier-one
approved these changes
Nov 13, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1075 +/- ##
================================================
Coverage ? 34.4014%
================================================
Files ? 109
Lines ? 11360
Branches ? 0
================================================
Hits ? 3908
Misses ? 7031
Partials ? 421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1066 to release-4.0
What problem does this PR solve?
Some goroutines in owner changefeed internal routines are not exited when changefeed is paused or stopped.
What is changed and how it works?
Check List
Tests
Release note