Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add more test cases in pkg, remove unused functions #1070

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Add test cases in pkg module

What is changed and how it works?

add test cases

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei amyangfei added component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. labels Nov 11, 2020
@amyangfei amyangfei added this to the v4.0.9 milestone Nov 11, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Nov 11, 2020
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 13, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 13, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 13, 2020
@zier-one
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 13, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #1070 (560960a) into master (51c1822) will increase coverage by 0.1302%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #1070        +/-   ##
================================================
+ Coverage   34.2796%   34.4099%   +0.1302%     
================================================
  Files           107        109         +2     
  Lines         11377      11363        -14     
================================================
+ Hits           3900       3910        +10     
+ Misses         7055       7032        -23     
+ Partials        422        421         -1     

@ti-srebot ti-srebot merged commit d1303b9 into pingcap:master Nov 13, 2020
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Nov 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1074

@amyangfei amyangfei deleted the add-more-unit-tests branch November 13, 2020 08:43
ti-srebot added a commit that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants