Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv (ticdc): Improve the codebase of kvClient. (#10585) #10608

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10585

What problem does this PR solve?

Issue Number: ref #10584

What is changed and how it works?

  • Move stream related filed into eventFeedStream struct to make the code more clear.
  • Reduce a lock usage by make sure the storeStreamsCache can only be accessed in one goroutine.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign glorv for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 18, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify ae72a11 link true /test verify
pull-dm-integration-test ae72a11 link true /test dm-integration-test
pull-cdc-integration-storage-test ae72a11 link true /test cdc-integration-storage-test
pull-cdc-integration-pulsar-test ae72a11 link true /test cdc-integration-pulsar-test
pull-cdc-integration-mysql-test ae72a11 link true /test cdc-integration-mysql-test
pull-cdc-integration-kafka-test ae72a11 link true /test cdc-integration-kafka-test
pull-dm-compatibility-test ae72a11 link true /test dm-compatibility-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@asddongmen asddongmen closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants