-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv (ticdc): fix kvClient reconnection downhill loop (#10559) #10571
Merged
ti-chi-bot
merged 7 commits into
pingcap:release-7.1
from
ti-chi-bot:cherry-pick-10559-to-release-7.1
Feb 26, 2024
Merged
kv (ticdc): fix kvClient reconnection downhill loop (#10559) #10571
ti-chi-bot
merged 7 commits into
pingcap:release-7.1
from
ti-chi-bot:cherry-pick-10559-to-release-7.1
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
area/ticdc
Issues or PRs related to TiCDC.
component/kv-client
TiKV kv log client component.
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/cherry-pick-for-release-7.1
This PR is cherry-picked to release-7.1 from a source PR.
labels
Jan 31, 2024
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jan 31, 2024
asddongmen
approved these changes
Feb 26, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…10559-to-release-7.1
/retest |
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
area/ticdc
Issues or PRs related to TiCDC.
cherry-pick-approved
Cherry pick PR approved by release team.
component/kv-client
TiKV kv log client component.
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
type/cherry-pick-for-release-7.1
This PR is cherry-picked to release-7.1 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10559.
This also contains an manual cherry-pick of #10585.
What problem does this PR solve?
Issue Number: close #10239
What is changed and how it works?
eventFeedStream
struct to identify a stream and prevent it from being deleted unexpectedly.eventFeedStream
to prevent the stream from being canceled unexpectedly.s.deleteStream
to only once to prevent the stream from being deleted unexpectedly.Check List
Tests
time.sleep(5 * time.second)
before callings.deleteStream
in both unfixed and fixed version of code.unfixed cdc:
fixed cdc:
From the above graphs, it is evident that in the unfixed CDC, the lag of resolvedTs can exceed 12 minutes when a TiKV node is restarted. However, in the fixed CDC, the increase in resolvedTs is limited to a maximum of 35 seconds. This demonstrates the effectiveness of the fix.
Moreover, when the hard-coded
time.sleep(5 * time.second)
is removed and the fixed version of CDC is tested again, the lag becomes even smaller:Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note